chore(web): delete unwired memory api copy and orphan scaffold by daggerstuff · Pull Request #6485 · daggerstuff/pixelated

daggerstuff · 2026-11-03T09:24:05Z

Summary

Nightly audit area 2 — subtraction-only cleanup in apps/web: remove scaffold with no live importers (verified with rg across @/, ~/, relative paths, configs, and docs-as-config). Live memory API, auth forms, blog cards, nav, and polyfills are unchanged.

Deleted

Duplicate memory API (`src/api/memory/**`)

Routes, _shared.ts, and unit tests under src/api/memory/ (not wired to Astro; production contract is src/pages/api/memory/**).
Removed apps/web/src/api/memory/__tests__/**/*.test.ts glob from root vitest.config.ts.

Legacy auth components

Login.tsx, Register.tsx, AuthButtons.tsx, AuthCard.astro, RequireRole.tsx — pages use LoginForm / RegisterForm; auth/index.ts only exports ProtectedRoute.

Orphan blog UI

ArticleCard, ArticleHeader, AuthorBio, Divider, Pagination, SeriesNavigation, SocialShare, Subscribe, TableOfContents (.astro), plus BlogSearch.tsx.
Kept PostCard.astro (imported by pages/blog/series/[name].astro and pages/blog/tag/[tag].astro).

Todo demos

TodoAlpine.astro, TodoComponent.astro, TodoIsland.astro, TodoPreactIsland.astro, TodoReact.tsx — self-contained demo chain with no page importers.
Removed 82 corresponding pins from scripts/ci/tech-debt-baseline.json.

Superseded layout / polyfill / shim

Root Navbar.astro, Hamburger.astro, Monitoring.astro — docs use @/components/mizu/Navbar.astro; RUM uses monitoring/RealUserMonitoring.astro.
src/buffer-polyfill.js — live copy is public/polyfills/buffer-polyfill.js.
analytics/PatternVisualization.tsx re-export shim — tests and app code import PatternVisualizationReact.tsx directly.

Committed Playwright artifacts

Removed apps/web/public/test-results/** (62 error-context.md files).
Added apps/web/public/test-results/ to .gitignore.

Test maintenance

source-map.test.mjs: example path updated to mizu/Navbar.astro after deleting root Navbar.astro.

Kept (live importers)

Path	Why
`src/pages/api/memory/**`	Served memory API; `vercel.json` rewrite + route-config auth rules
`@/pages/api/memory/_shared`	Imported by developer API key routes
`components/auth/LoginForm.tsx`, `RegisterForm.tsx`, `ProtectedRoute.tsx`, …	Used by `login.astro` / `register.astro`
`components/blog/PostCard.astro`	Blog series/tag pages
`components/mizu/Navbar.astro`	`DocumentationLayout.astro`
`components/analytics/PatternVisualizationReact.tsx`	Direct imports in tests and UI
`public/polyfills/buffer-polyfill.js`	Loaded by `client-entry.js` / feature detector

Note: Some content-store/blog/*.md files contain <ArticleCard>-style tags, but nothing registers those components for Markdown rendering and no TS/Astro importer references the deleted .astro files — tags were inert.

Proof

Check	Result
`pnpm lint`	Pass
`pnpm build`	Pass
`pnpm vitest run -c config/vitest.config.ts`	No new failing files vs staging baseline

Vitest baseline (`staging`, before changes)

10 failing test files (25 failing tests):

apps/web/src/lib/audit/__tests__/chain.test.ts
apps/web/src/lib/audit/__tests__/logger.test.ts
apps/web/src/lib/db/__tests__/db-ssl-config.test.ts
apps/web/src/lib/ehr-native/auth/ehr-rbac.test.ts
apps/web/src/lib/governance/__tests__/compliance-validator.test.ts
apps/web/src/lib/governance/__tests__/fhe-integration.test.ts
apps/web/src/lib/graphql/__tests__/graphql.test.ts
apps/web/src/api/routes/__tests__/auth.test.ts
apps/web/src/tests/api/session/skills-api.test.ts
apps/web/src/components/ai/chat/__tests__/useChatCompletion.test.ts

Baseline summary: 10 failed | 474 passed | 2 skipped (486 files); 6920 tests passed.

Vitest on this branch

Same 10 failing files (no additions). Summary: 10 failed | 471 passed | 2 skipped (483 files) — three fewer files because deleted src/api/memory/__tests__/* are gone. 6884 tests passed (−36 tests from removed memory unit tests).

Net diff

101 files, +9 / −19,679 lines (commit stat).

Out of scope

Open PRs chore: remove unwired markdown and vite plugin trees #6466 (remark/rehype/vite plugins) and chore: delete dead ci surfaces #6470 (dead CI surfaces) untouched.
EHR and threat-intelligence code untouched.

Summary by Sourcery

Clean up unreferenced web application code and generated artifacts while preserving the live routes, components, and polyfills.

Enhancements:

Remove unused web scaffolding, duplicate memory API code, legacy authentication and blog components, demo todo implementations, superseded UI shims, and other orphaned files.

CI:

Stop collecting tests from the deleted memory API test directory and reduce the tracked technical-debt baseline accordingly.

Tests:

Update the source-map test fixture to reference the active documentation navbar.

Chores:

Delete committed Playwright error artifacts and ignore the generated test-results directory.

vercel · 2026-11-03T09:24:09Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
pixelated	Ready	Preview	Nov 3, 2026 2:12pm UTC

sourcery-ai · 2026-11-03T09:24:10Z

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This subtraction-only cleanup removes verified-unwired duplicate APIs, legacy UI components, demo chains, superseded shims, and committed test artifacts from apps/web, updates test and tech-debt configuration accordingly, and preserves the live memory API, authentication flows, blog card, navbar, polyfill, and analytics implementation. Lint and build pass, while Vitest retains the same pre-existing failing test files with only the deleted memory tests removed.

File-Level Changes

Change	Details	Files
Remove the duplicate, unwired memory API implementation and its tests while preserving the routed `src/pages/api/memory` implementation.	Deleted duplicate memory routes and shared helpers. Deleted the associated memory unit tests. Removed the deleted test directory from Vitest configuration.	`apps/web/src/api/memory/**` `vitest.config.ts`
Delete legacy authentication, blog, demo, layout, monitoring, polyfill, and analytics scaffold that has no live importers.	Removed superseded auth components while retaining the active form and protected-route components. Removed orphaned blog components and demos while retaining `PostCard.astro`. Removed obsolete layout, monitoring, polyfill, and analytics shim files in favor of their active replacements.	`apps/web/src/components/auth/` `apps/web/src/components/blog/` `apps/web/src/components/BlogSearch.tsx` `apps/web/src/components/Todo*.astro` `apps/web/src/components/TodoReact.tsx` `apps/web/src/components/Navbar.astro` `apps/web/src/components/Hamburger.astro` `apps/web/src/components/Monitoring.astro` `apps/web/src/buffer-polyfill.js` `apps/web/src/components/analytics/PatternVisualization.tsx`
Clean up generated artifacts and stale maintenance metadata associated with the removed scaffold.	Deleted committed Playwright error-context artifacts and ignored future `public/test-results` output. Removed corresponding todo entries from the tech-debt baseline. Updated the sourcemap test fixture to reference the surviving Mizu navbar.	`apps/web/public/test-results/**` `.gitignore` `scripts/ci/tech-debt-baseline.json` `apps/web/src/lib/sentry/source-map.test.mjs`

Possibly linked issues

#: PR deletes numerous unused Astro/React UI components and updates the CI tech-debt baseline, directly matching the issue’s cleanup.
#: The PR directly removes orphaned web source modules and updates test and baseline references, matching the issue’s requested cleanup.

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

github-actions · 2026-11-03T09:25:17Z

px Advisor Review

Risk: unknown

No summary available

No findings.

sourcery-ai

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

github-actions · 2026-11-03T09:28:04Z

Lighthouse CI Results

Routes audited: /, /dashboard?perf=1, /training-session

Thresholds: Performance ≥90 | Accessibility ≥90 | Best Practices ≥85

Reports

lhr-1793697990020
lhr-1793698001724
lhr-1793698013002
lhr-1793698023814
lhr-1793698034518
lhr-1793698045186
lhr-1793698055870
lhr-1793698066540
lhr-1793698077210

Reports are also available as workflow artifacts

Remove duplicate src/api/memory tree, legacy auth/blog/todo/nav demos, committed Playwright artifacts, and related CI baselines. Live routes remain under src/pages/api/memory and mizu/Navbar.

github-actions · 2026-11-03T14:11:39Z

Lighthouse CI Results

Routes audited: /, /dashboard?perf=1, /training-session

Thresholds: Performance ≥90 | Accessibility ≥90 | Best Practices ≥85

Reports

lhr-1793715007882
lhr-1793715019328
lhr-1793715030343
lhr-1793715040945
lhr-1793715051516
lhr-1793715062088
lhr-1793715072687
lhr-1793715083226
lhr-1793715093784

Reports are also available as workflow artifacts

github-actions · 2026-11-03T14:12:33Z

px Advisor Review

Risk: unknown

No summary available

No findings.

github-actions · 2026-11-03T14:22:33Z

px Advisor Review

Risk: unknown

No summary available

No findings.

github-actions · 2026-11-03T14:26:11Z

Lighthouse CI Results

Routes audited: /, /dashboard?perf=1, /training-session

Thresholds: Performance ≥90 | Accessibility ≥90 | Best Practices ≥85

Reports

lhr-1793715871525
lhr-1793715884201
lhr-1793715896394
lhr-1793715907813
lhr-1793715919111
lhr-1793715930429
lhr-1793715941763
lhr-1793715953019
lhr-1793715964374

Reports are also available as workflow artifacts

linear-code · 2026-11-03T14:40:46Z

PIX-4830

github-actions Bot added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 3, 2026

vercel Bot deployed to Preview November 3, 2026 09:26

View deployment

sourcery-ai Bot approved these changes Nov 3, 2026

View reviewed changes

daggerstuff force-pushed the cursor/delete-unwired-web-scaffold-ead9 branch from 7d54a2a to aeeac0e Compare November 3, 2026 14:05

chore(web): delete unwired memory api copy and orphan scaffold

7e6262e

Remove duplicate src/api/memory tree, legacy auth/blog/todo/nav demos, committed Playwright artifacts, and related CI baselines. Live routes remain under src/pages/api/memory and mizu/Navbar.

daggerstuff force-pushed the cursor/delete-unwired-web-scaffold-ead9 branch from aeeac0e to 7e6262e Compare November 3, 2026 14:08

vercel Bot deployed to Preview November 3, 2026 14:12

View deployment

daggerstuff merged commit db0ab5f into staging Nov 3, 2026
40 of 43 checks passed

daggerstuff deleted the cursor/delete-unwired-web-scaffold-ead9 branch November 3, 2026 14:40

Conversation

daggerstuff commented Nov 3, 2026 • edited by sourcery-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Deleted

Duplicate memory API (src/api/memory/**)

Legacy auth components

Orphan blog UI

Todo demos

Superseded layout / polyfill / shim

Committed Playwright artifacts

Test maintenance

Kept (live importers)

Proof

Vitest baseline (staging, before changes)

Vitest on this branch

Net diff

Out of scope

Summary by Sourcery

Uh oh!

vercel Bot commented Nov 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sourcery-ai Bot commented Nov 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

File-Level Changes

Possibly linked issues

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

github-actions Bot commented Nov 3, 2026

px Advisor Review

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Sourcery assessment

Uh oh!

github-actions Bot commented Nov 3, 2026

Lighthouse CI Results

Reports

Uh oh!

github-actions Bot commented Nov 3, 2026

Lighthouse CI Results

Reports

Uh oh!

github-actions Bot commented Nov 3, 2026

px Advisor Review

Uh oh!

github-actions Bot commented Nov 3, 2026

px Advisor Review

Uh oh!

github-actions Bot commented Nov 3, 2026

Lighthouse CI Results

Reports

Uh oh!

Uh oh!

linear-code Bot commented Nov 3, 2026

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

daggerstuff commented Nov 3, 2026 •

edited by sourcery-ai Bot

Loading

Duplicate memory API (`src/api/memory/**`)

Vitest baseline (`staging`, before changes)

vercel Bot commented Nov 3, 2026 •

edited

Loading

sourcery-ai Bot commented Nov 3, 2026 •

edited

Loading